-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26902/
-----------------------------------------------------------

(Updated Oct. 20, 2014, 5:54 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Update to fail the build if threshold is exceeded. Refactor a bit along the way.


Repository: aurora


Description
-------

Add a message when coverage exceeds minimum. This way we'll be sure to 
continually raise the minimum threshold as we exceed it.


Diffs (updated)
-----

  buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 
390acf7c453f18fa968dd3ce60131fc7d80d69f6 

Diff: https://reviews.apache.org/r/26902/diff/


Testing (updated)
-------

./gradlew test

With values artificially set lower it outputs:

Instruction coverage of 0.87 exceeds min instruction coverage of 0.86, consider 
raising the bar!
Branch coverage of 0.82 exceeds min instruction coverage of 0.81, consider 
raising the bar!

(we're at 0.8793488824101069 for instruction coverage, so close to bumping that 
up).


New output after updating to fail the build if thresholds are exceeded (showing 
the fact that we capture failures in a single run for both below and above 
threshold):

    FAILURE: Build failed with an exception.

    * What went wrong:
    Execution failed for task ':analyzeReport'.
        > Instruction coverage of 0.87 exceeds min instruction coverage of 
0.86, please raise the threshold!
          Branch coverage must be greater than 0.83


Thanks,

Joshua Cohen

Reply via email to