-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/#review57364
-----------------------------------------------------------



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98014>

    s/is summarizing/summarizes/



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98015>

    s/ in a datacenter//



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98017>

    Consider consistently using the term "Replicated log" instead of "Mesos 
log" or "Mesos replicated log".  The rest is implementation detail.



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98019>

    Remove - redundant to the section title.



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98020>

    s/drive/disk/



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98021>

    ZooKeeper (capital K)



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98023>

    "The interval on which the scheduler writes local storage backups.  The 
default is every hour."



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98027>

    Directory to write backups to.



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98028>

    s/Max/Maximum/
    
    s/them oldest first/the oldest backup(s)/



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98030>

    s/Mesos //



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98029>

    Comment not addressed in the last round:
    
    "requires full scheduler outage" is ambiguous, and sounds scary.  How about 
"requires all schedulers to be taken down temporarily while restoring."



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98031>

    s/from backup/from a backup/



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98035>

    Before going into the configuration changes, can you offer a little 
context?  Without any background, they don't offer any guidance about why we're 
doing these seemingly-strange things.



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98036>

    s/from backup/from a backup/



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98039>

    This needs more detail, especially because the scheduler exhibits this 
behavior out of the box (every 24 hours).



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98043>

    Ok - that was the first thing i thought when reading this: why not make the 
procedure completely uniform.  I think this will be much easier to follow if 
there is only one path to follow, considering that the reader needing this doc 
is likely already in a panic.



docs/storage-config.md
<https://reviews.apache.org/r/26851/#comment98040>

    s/ snapshot//


- Bill Farner


On Oct. 17, 2014, 9:47 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26851/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 9:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
>     https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Summarizing recovery from backup steps.
> 
> 
> Diffs
> -----
> 
>   docs/storage-config.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26851/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_config_doc/docs/storage-config.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to