----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26956/#review57459 -----------------------------------------------------------
It's not entirely clear from the screenshot that "LOCAL" is a reference to the timezone. Maybe it's the fact that it's capitalized, but it feels more related to the task state than the time (I'm envisioning questions like "what does LOCAL - PENDING mean?"). Am I being crazy? Would it make sense to change it to something like "(local time)", or even better, instead of hardcoding "LOCAL" maybe just display their actual time zone identifier (or, since that's a minor hassle from JS, maybe just the offset)? - Joshua Cohen On Oct. 20, 2014, 10:55 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26956/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 10:55 p.m.) > > > Review request for Aurora, Joshua Cohen and Kevin Sweeney. > > > Bugs: AURORA-873 > https://issues.apache.org/jira/browse/AURORA-873 > > > Repository: aurora > > > Description > ------- > > Fixes the AM/PM issue by using 24 hour clock format that was already defined > in filters.js. > > > Diffs > ----- > > src/main/resources/scheduler/assets/js/controllers.js > f8e2eb7b896843bb19ad3ea5108532209603c73c > src/main/resources/scheduler/assets/taskStatus.html > ae32866ff241e18d04a82e8a7f909cb692657188 > > Diff: https://reviews.apache.org/r/26956/diff/ > > > Testing > ------- > > See attached screenshot. > > > File Attachments > ---------------- > > screenshot > > https://reviews.apache.org/media/uploaded/files/2014/10/20/d89be4fc-7fae-4746-841a-ccaf66e2439e__Screen_Shot_2014-10-20_at_3.55.15_PM.png > > > Thanks, > > David McLaughlin > >
