> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 22
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line22>
> >
> >     s/is summarizing/summarizes/

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 23
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line23>
> >
> >     s/ in a datacenter//

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 32
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line32>
> >
> >     Consider consistently using the term "Replicated log" instead of "Mesos 
> > log" or "Mesos replicated log".  The rest is implementation detail.

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 34
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line34>
> >
> >     Remove - redundant to the section title.

Dropped.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 42
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line42>
> >
> >     s/drive/disk/

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 46
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line46>
> >
> >     ZooKeeper (capital K)

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 56
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line56>
> >
> >     "The interval on which the scheduler writes local storage backups.  The 
> > default is every hour."

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 60
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line60>
> >
> >     Directory to write backups to.

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 63
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line63>
> >
> >     s/Max/Maximum/
> >     
> >     s/them oldest first/the oldest backup(s)/

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 79
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line79>
> >
> >     Comment not addressed in the last round:
> >     
> >     "requires full scheduler outage" is ambiguous, and sounds scary.  How 
> > about "requires all schedulers to be taken down temporarily while 
> > restoring."

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 78
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line78>
> >
> >     s/Mesos //

Obviated by the decision to use "Mesos replicated log" as suggested above.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 90
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line90>
> >
> >     s/from backup/from a backup/

Done.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 100
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line100>
> >
> >     Before going into the configuration changes, can you offer a little 
> > context?  Without any background, they don't offer any guidance about why 
> > we're doing these seemingly-strange things.

Added.


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 113
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line113>
> >
> >     s/from backup/from a backup/

removed


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 118
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line118>
> >
> >     This needs more detail, especially because the scheduler exhibits this 
> > behavior out of the box (every 24 hours).

removed


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 138
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line138>
> >
> >     Ok - that was the first thing i thought when reading this: why not make 
> > the procedure completely uniform.  I think this will be much easier to 
> > follow if there is only one path to follow, considering that the reader 
> > needing this doc is likely already in a panic.

removed


> On Oct. 20, 2014, 5:56 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 144
> > <https://reviews.apache.org/r/26851/diff/3/?file=724940#file724940line144>
> >
> >     s/ snapshot//

done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/#review57364
-----------------------------------------------------------


On Oct. 17, 2014, 9:47 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26851/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 9:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
>     https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Summarizing recovery from backup steps.
> 
> 
> Diffs
> -----
> 
>   docs/storage-config.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26851/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_config_doc/docs/storage-config.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to