> On Oct. 21, 2014, 3:15 p.m., Kevin Sweeney wrote:
> > This end-to-end test runs against all components (it recently caught an 
> > executor build break). Any reason not to build them all here?
> 
> Joshua Cohen wrote:
>     +1, I'd say build them all by default but maybe add an env switch to skip 
> building for speedier iteration during development (last step before posting 
> review should still be to run the tests with cleanly built artifacts ofc).
> 
> Maxim Khutornenko wrote:
>     Thought about that but given that it's mostly a client validation suite 
> decided to keep it lean for better perf. I am happy to add other components 
> if no objection.

It's doing a lot more than just validating the client, for example it verifies 
that the serverset announcer functionality of the executor is tested, as well 
as a test of the full communication path 
(client<->scheduler<->mesos-master<->mesos-slave<->executor) with real libmesos 
binaries. We just use client output as a proxy for this because it's convenient.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26998/#review57679
-----------------------------------------------------------


On Oct. 21, 2014, 3:29 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26998/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 3:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-498
>     https://issues.apache.org/jira/browse/AURORA-498
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Building aurora client/admin before running e2 tests.
> 
> 
> Diffs
> -----
> 
>   src/test/sh/org/apache/aurora/e2e/test_common.sh 
> 43d2516133c6d6cdb4236358f942396f057f739c 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 324aa4dbeff00e673fe73b87e3a0766856cd213c 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 
> 
> Diff: https://reviews.apache.org/r/26998/diff/
> 
> 
> Testing
> -------
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to