> On Oct. 22, 2014, 2:41 p.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/client/cli/test_status.py, line 81
> > <https://reviews.apache.org/r/27047/diff/1/?file=728832#file728832line81>
> >
> >     spec?

I'll do better than spec: there's no reason for that to be a mock at all.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27047/#review57851
-----------------------------------------------------------


On Oct. 22, 2014, 1:57 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27047/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 1:57 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-879
>     https://issues.apache.org/jira/browse/aurora-879
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Sort tasks by instance number.
> - Sort events by timestamp.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 10f8e0d331ca607e55e3aa6f96014caea744ed9f 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4f62cf0c52e5837309cf7ad702df6d907df8f510 
> 
> Diff: https://reviews.apache.org/r/27047/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/cli:job
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  job)])
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 58 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ...........
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ................
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> 
> ========================== 58 passed in 3.65 seconds 
> ===========================
> src.test.python.apache.aurora.client.cli.job                                  
>   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to