-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review57911
-----------------------------------------------------------

Ship it!



src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/26531/#comment98806>

    -1 indent



src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/26531/#comment98816>

    Mind adding a note about what happens when an unknown job update is 
referenced?


- Bill Farner


On Oct. 21, 2014, 5:58 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 5:58 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
> 
> 
> Bugs: AURORA-690
>     https://issues.apache.org/jira/browse/AURORA-690
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Defining the flag and the schema for the update coordination (aka heartbeats).
> 
> 
> Diffs
> -----
> 
>   build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e792d23d6bb13b4e61b078beea6d063f72f0d8fc 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  77032d84f91b149c01ce4ac62da7ca331a2b6445 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> db6a8719d18fee720f74ebcd2079ad36201cc831 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 401083621e1a1bbe43751b8bd168277543b9a812 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  3871dae68fcdc6402cb61a7244b46114617eecff 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 076008e400bd9200cfd70fc469a4c310f291d70f 
> 
> Diff: https://reviews.apache.org/r/26531/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to