> On Oct. 22, 2014, 3:07 p.m., Bill Farner wrote:
> > config/legacy_untested_classes.txt, line 9
> > <https://reviews.apache.org/r/27044/diff/1/?file=728771#file728771line9>
> >
> >     In the interest of this file being delete only, can you bite the bullet 
> > and create a unit test to cover these in a test?

That invovles doing this "TODO(wfarner): Try to accomplish all this by 
subclassing SchedulerMain and actually using AppLauncher." in SchedulerIT. I 
feel that deserves its own RB.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review57917
-----------------------------------------------------------


On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 9:57 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
>     https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 048740953629a950c136179c9b880b8dce8fa932 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> e9f251508257cd7287ff00773e0073a3cd130df8 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  283f7e1e22decfe1053bd5640e8283b40eeac592 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> c405d4c8b127c2dd7054c9520064da0346690f02 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to