> On Oct. 23, 2014, 3:32 p.m., Kevin Sweeney wrote:
> > Driveby comment: Consider using Guice's FactoryModuleBuilder to minimize 
> > the factory boilerplate needed. IMO this should be the default anytime you 
> > want a factory that gets some of its dependencies from Guice, as the 
> > created objects will be instrumentable by Guice AOP.

This is a great idea. I'm looking into it now.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review58146
-----------------------------------------------------------


On Oct. 23, 2014, 4:06 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 4:06 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
>     https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to