-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25794/#review58219
-----------------------------------------------------------


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Sept. 18, 2014, 9:38 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25794/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 9:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, 
> and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a mock scheduler client to the AuroraClient service.
> 
> There is probably a more Angular way to get this done which involves creating 
> a mock service, but this seemed like the simplest approach.
> 
> Interested in whether this is the right place to do mocking (or should it 
> come from the server so that we have more coverage of the client code?) or if 
> we should mock at all. 
> 
> Code itself needs cleaned up - I just want to solicit feedback before I go 
> too far down a bad path. 
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 8a719f85b0a095a93b723c04b0a5e8306093c572 
> 
> Diff: https://reviews.apache.org/r/25794/diff/
> 
> 
> Testing
> -------
> 
> In Chrome -> Developer Console:
> 
> window.__mockAPI__ = true;
> 
> Now I have updates in the UI. 
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to