-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26753/#review58215
-----------------------------------------------------------


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 21, 2014, 6:34 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26753/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 6:34 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: aurora-131
>     https://issues.apache.org/jira/browse/aurora-131
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Make the "aurora2" main target be the standalone clientv2;
> - Don't build the bridged client by default; but allow forced build using 
> "aurora2_bridge".
> - Modify cli tests so that they only depend on the standalone clientv2.
> - Modify vagrant config to make clientv2 the primary client.
> - Modify end-to-end tests to match the vagrant changes.
> 
> (Note: end-to-end tests are failing, but in the same way as they fail without 
> this change. I'm working on debugging that, but it should be its own 
> change/review, and I don't want to delay reviewing this.)
> 
> 
> Diffs
> -----
> 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 8659bffb8fb6170c02aef0edce92349540d4366a 
>   examples/vagrant/provision-dev-cluster.sh 
> 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 995570325bbb09ecbcc2ace5d223760c5d49367f 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 95aa649cfff9166dd10aa432c4d470739e8f06c5 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> e7052465411165acb3d5145664f2f166ac052500 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 9fc6fe2c2063cda494437d83044557b345acacea 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> dfcbd7217b1d51609fa01c4d9cefed5471c91718 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 328297ab1d29efb0adce8f4931a13929a04dcd9c 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> c7b71c29d44150162fec8066947623fa91815424 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 10817695352687cdb5b0c3ed9720e3091b230e68 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 551c9f949cda3971a370cb696216ec9584584336 
>   src/test/python/apache/aurora/client/cli/test_inspect.py 
> e997b9743b63d71f8624ecf5ca1dcae0227be70d 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> f7601d82dbb45900bec2939dca2b921bf147961d 
>   src/test/python/apache/aurora/client/cli/test_logging.py 
> 9ca4dceeaa87d5fb2e38fe0d83fdcdf1ee597a0e 
>   src/test/python/apache/aurora/client/cli/test_open.py 
> c20649f5cada241d0f6e9ae5f88d300eac073517 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> dc5edd4f03cee062673231a04908193480c8071c 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 88fb9aec4d1eae6ad05da01752a670f902bafb1b 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> a753ab4aead7e2560cae77c441562811924f8f1b 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> a1a3d8161ba747aa23a5e614e9ae31473d2058c1 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4f62cf0c52e5837309cf7ad702df6d907df8f510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> f3fa6cf6e9e080689593c40e787018eff46f8ede 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 16fde14c03f6fd2c000e76625fad174835763f1b 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> cff1b6578aec6f5bcc1e610e58b47af233f32b41 
>   src/test/sh/org/apache/aurora/e2e/test_common.sh 
> 43d2516133c6d6cdb4236358f942396f057f739c 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 324aa4dbeff00e673fe73b87e3a0766856cd213c 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 
> 
> Diff: https://reviews.apache.org/r/26753/diff/
> 
> 
> Testing
> -------
> 
> - Ran all unit tests, confirmed they continue to pass.
> - Ran end-to-end tests (both v1 and v2 variants) with the updated setup, and 
> verified that they fail in exactly the same way as before this change.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to