-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58299
-----------------------------------------------------------


Does it make sense to use the ReviewBoard Python client from rbtools? 
https://www.reviewboard.org/docs/rbtools/0.5/api/overview/

What is the plan to actually run this script? Is it safe to assume that it will 
be executed from an up to date git repo, or will it need to git pull?


build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/27145/#comment99248>

    Our Python continuation indent style is generally the same as our Java 
style, so these should be indented 4 past the parent, not aligned?


- Joshua Cohen


On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27145/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 5:32 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-883
>     https://issues.apache.org/jira/browse/AURORA-883
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I also removed `--stacktrace` from the gradle command.  This makes for better 
> tail output.  I originally added `--stacktrace` to help debug build flakiness 
> we were having due to jenkins machine configuration (but haven't had in a 
> very long time): https://reviews.apache.org/r/23776/
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 
>   build-support/jenkins/review_feedback.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27145/diff/
> 
> 
> Testing
> -------
> 
> I've run this a handful of times on my workstation, it seems to be doing its 
> job.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to