> On Oct. 24, 2014, 2:10 p.m., Maxim Khutornenko wrote:
> > It's not obvious from the diff: where do we gain perf? Can you point to the 
> > place where we don't do store calls anymore?

If you notice in `SchedulingFilterImplTest.java` many of the tests no longer 
make calls to the maintenance controller. This is a performance gain because 
the maintenance controller makes a consistent read from the AttributeStore. 
Since this read is ommitted from every time we call the scheduling filter we 
gain performance.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58374
-----------------------------------------------------------


On Oct. 24, 2014, 12:59 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 12:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
>     https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to