-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27082/#review58647
-----------------------------------------------------------


Does this only log the error, or does the exit code change to non-zero as well?
If it's only logged, maybe the `aurora job create` command should also support 
the --write-json argument and log the error in json?

Thanks,
Alex

- Alex Levenson


On Oct. 23, 2014, 6:44 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27082/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 6:44 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-886
>     https://issues.apache.org/jira/browse/aurora-886
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make "job create" return an error if the job wasn't created successfully.
> 
> "job create" now calls the api check_status method, and generates an error 
> message like the following if it doesn't find the created job:
> 
> {noformat}
> "Error occurred while creating job west/bozo/test/hello"]
> {noformat}
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 10f8e0d331ca607e55e3aa6f96014caea744ed9f 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 9fc6fe2c2063cda494437d83044557b345acacea 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 328297ab1d29efb0adce8f4931a13929a04dcd9c 
> 
> Diff: https://reviews.apache.org/r/27082/diff/
> 
> 
> Testing
> -------
> 
> Added new test, ran all unit tests.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to