> On Oct. 28, 2014, 5:04 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java, 
> > line 67
> > <https://reviews.apache.org/r/27262/diff/1/?file=734815#file734815line67>
> >
> >     Is the cargo cult of the code below necessary?

I was hestitant to invest more given a throwaway nature of this change. 
Refactored.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27262/#review58825
-----------------------------------------------------------


On Oct. 28, 2014, 1:43 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27262/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 1:43 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-899
>     https://issues.apache.org/jira/browse/AURORA-899
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding missing JobConfiguration backfill for task config job field.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> 97517ed609289f584e07620d24f6fc09c54d36fc 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 32a90d5a7819404a3d9e0b94168a447398607e56 
> 
> Diff: https://reviews.apache.org/r/27262/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to