> On Oct. 30, 2014, 9:49 a.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/http/QuitCallbackTest.java, lines > > 38-43 > > <https://reviews.apache.org/r/27375/diff/1/?file=742747#file742747line38> > > > > Maybe nitpicky, but should the behavior under test here be that > > Lifecycle#shutdown is invoked, rather than that Lifecycle will execute the > > command when shutdown is called? I.e., instead of setting up a QuitCallback > > with a real Lifecycle that's given a mock Command, just set it up with a > > mock Lifecycle and assert that shutdown is called? The former relies on > > knowledge of what Lifecycle does on shutdown which seems out of scope for > > this test.
That was actually my initial approach, but Lifecycle is a class and shutdown is final, disqualifying it for EasyMock. As we progress down this path, we will translate Lifecycle into an interface. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27375/#review59162 ----------------------------------------------------------- On Oct. 30, 2014, 6:02 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27375/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 6:02 a.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > We were only using this for DefaultQuitHandler, which is easy enough to > replace. > > Additionally, common:io is only used in tests. > > > Diffs > ----- > > build.gradle 719ceb75aa462a7e3d0f06602facdd866f18ee5d > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 958f60c9d804af4c915a53ccdaf489a91ee284c7 > src/main/java/org/apache/aurora/scheduler/http/QuitCallback.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/QuitCallbackTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27375/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
