----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/#review59206 -----------------------------------------------------------
Ship it! src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java <https://reviews.apache.org/r/27371/#comment100489> s/public// src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java <https://reviews.apache.org/r/27371/#comment100487> Any reason it has to be Number here? - Maxim Khutornenko On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27371/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 5:09 a.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-884 > https://issues.apache.org/jira/browse/AURORA-884 > > > Repository: aurora > > > Description > ------- > > This change also alters the coverage check, which would always trip for > anonymous classes like `TypeLiteral` and `Clazz`. > > > Diffs > ----- > > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy > 06d25c065b5c4272ccc011bd884440b2201b5782 > config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 90b26e573e530950314b28a47121acc5195e2f94 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java > 31498fae3e24a38e723c83ae44543b5d806c0795 > src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java > abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 > src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java > 273129eb1f00ed8e116fba405e5db6a5a6170a8b > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 61b6b8e872120a0106141f9fd7527d71d282624d > > Diff: https://reviews.apache.org/r/27371/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
