> On Oct. 29, 2014, 9:41 p.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/executor/test_executor_builds.py, line 32 > > <https://reviews.apache.org/r/27364/diff/1/?file=742184#file742184line32> > > > > It's pip installable for linux, right? > > > > Can we do skipif platform != linux? > > Kevin Sweeney wrote: > not pip-installable without setting a distro-specific custom pypi mirror > (or building one and dropping it into third_party). Given that it's already > ignored in the pants version of the build (commented in the `BUILD` file) > this is just adding parity so that other invocations of py.test (that don't > gather test targets the same way pants does) can work. Could also do > something like > > ```py > try: > import mesos.native as _ > mesos_native_present = True > except ImportError: > mesos_native_present = False > > # ... > > @pytest.mark.skipif("not mesos_native_present") > def test_noop(): > assert 1 == 1 > ``` > > Joshua Cohen wrote: > It'd be nice to do something so these tests run one way or another, > either via a CI env flag, or the mechanism described here. I'm ok taking care > of this in a follow up.
Filed https://issues.apache.org/jira/browse/AURORA-907 > On Oct. 29, 2014, 9:41 p.m., Joshua Cohen wrote: > > build-support/python/make-pycharm-virtualenv, line 24 > > <https://reviews.apache.org/r/27364/diff/1/?file=742139#file742139line24> > > > > should we write this under build-support/python? or does pycharm > > require this in the root? > > Kevin Sweeney wrote: > pycharm offers helpful suggestions if this is in root, but we could also > push it to `build-support/python`. > > Joshua Cohen wrote: > If it's better in the root, that's fine. Unfortunate that you can't set a > path to it, but what can you do. Left it in root, happy to revisit if this is a problem in the future. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364/#review59135 ----------------------------------------------------------- On Oct. 30, 2014, 10:16 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27364/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 10:16 a.m.) > > > Review request for Aurora, Joshua Cohen, Bill Farner, and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Note there are a few changes to test code to allow running without pants as > the test runner: > > * Use relative imports in test packages. > * Added blank `__init__.py` files to test directories that need to use > relative imports now. > * Catch PexInfo errors that result from not running inside a PEX. > * Add requirements.txt to .gitignore (we generate it from pants) - it helps > pycharm offer quick fixes and identify packages with updates available. > > To create a PyCharm project: > > Set the project interpreter to `build-support/python/pycharm.venv/bin/python`. > Mark `src/main/python` as a Sources Root. > Go to Settings > Python Integrated Tools and set `Default test runner` to > `py.test`. > > > Diffs > ----- > > .gitignore f551c88ea6a077c870b4bd60a640065f2e90e487 > build-support/python/make-pycharm-virtualenv PRE-CREATION > src/main/python/apache/aurora/client/cli/__init__.py > 376106c88abe6d06ef6f3cb7027ab8f66f052686 > src/main/python/apache/aurora/executor/executor_vars.py > 908d89fdcbdbbb33c9ddde26574244ba0476a524 > src/test/python/apache/aurora/client/api/__init__.py PRE-CREATION > src/test/python/apache/aurora/client/api/test_restarter.py > 2b264de71c7374646e3adddd63857b7650cd0f07 > src/test/python/apache/aurora/client/api/test_updater.py > a10e05ccb34942783ea8dd676461e5b9778adafb > src/test/python/apache/aurora/client/cli/__init__.py PRE-CREATION > src/test/python/apache/aurora/client/cli/test_api_from_cli.py > 4de8bb488b17d59ec2e43cd51a9f315e0b0ed4ba > src/test/python/apache/aurora/client/cli/test_cancel_update.py > e7052465411165acb3d5145664f2f166ac052500 > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 60c75300501c36ac20a97f78ff18b3ca7af30699 > src/test/python/apache/aurora/client/cli/test_config_noun.py > dfcbd7217b1d51609fa01c4d9cefed5471c91718 > src/test/python/apache/aurora/client/cli/test_create.py > a56d8b95c3e3521eb3f576427f361b6ac4cb10df > src/test/python/apache/aurora/client/cli/test_cron.py > c7b71c29d44150162fec8066947623fa91815424 > src/test/python/apache/aurora/client/cli/test_diff.py > 78694d7559f2041f27cd2a7e4cb81ca467f63ac2 > src/test/python/apache/aurora/client/cli/test_help.py > 551c9f949cda3971a370cb696216ec9584584336 > src/test/python/apache/aurora/client/cli/test_inspect.py > e997b9743b63d71f8624ecf5ca1dcae0227be70d > src/test/python/apache/aurora/client/cli/test_kill.py > f7601d82dbb45900bec2939dca2b921bf147961d > src/test/python/apache/aurora/client/cli/test_logging.py > 9ca4dceeaa87d5fb2e38fe0d83fdcdf1ee597a0e > src/test/python/apache/aurora/client/cli/test_open.py > c20649f5cada241d0f6e9ae5f88d300eac073517 > src/test/python/apache/aurora/client/cli/test_plugins.py > dc5edd4f03cee062673231a04908193480c8071c > src/test/python/apache/aurora/client/cli/test_quota.py > 88fb9aec4d1eae6ad05da01752a670f902bafb1b > src/test/python/apache/aurora/client/cli/test_restart.py > a753ab4aead7e2560cae77c441562811924f8f1b > src/test/python/apache/aurora/client/cli/test_sla.py > a1a3d8161ba747aa23a5e614e9ae31473d2058c1 > src/test/python/apache/aurora/client/cli/test_status.py > 8894a1e7998342d290221e803606c950f0a1f3c4 > src/test/python/apache/aurora/client/cli/test_supdate.py > f3fa6cf6e9e080689593c40e787018eff46f8ede > src/test/python/apache/aurora/client/cli/test_task_run.py > 12163df0d2e1e42f2a321603ec10ff9359848216 > src/test/python/apache/aurora/client/cli/test_update.py > 08f277e2b46f2bfe04a49ba6b8c2e40f64e5dd25 > src/test/python/apache/aurora/client/commands/__init__.py PRE-CREATION > src/test/python/apache/aurora/client/commands/test_admin.py > 769545ba86a669685001e4483d95091cfbfb4097 > src/test/python/apache/aurora/client/commands/test_admin_sla.py > 994b123fbd9e351859e918c74f9c2c0917b722e6 > src/test/python/apache/aurora/client/commands/test_cancel_update.py > 13aa1fef1d94d46f2837f500606028baa694fa6e > src/test/python/apache/aurora/client/commands/test_create.py > 4a753fb5942555854538047eb947e5465cdff607 > src/test/python/apache/aurora/client/commands/test_diff.py > 9f1d459e51c663b9ad62bbbbb16a8127568662d1 > src/test/python/apache/aurora/client/commands/test_hooks.py > d4d8d3cd15704353d958e1ef6b220eaa37696a4d > src/test/python/apache/aurora/client/commands/test_kill.py > 1e13b926379147295a3a1b3d6ce79a727719dedb > src/test/python/apache/aurora/client/commands/test_listjobs.py > f2a325ee025c78fcafab3f73a63c88c4245a7fee > src/test/python/apache/aurora/client/commands/test_maintenance.py > 13d753f6870c9f552903b077e3c38d306ead5bc4 > src/test/python/apache/aurora/client/commands/test_restart.py > efa0849c1f11d9304e2da981dfb9c1d0ff59a15d > src/test/python/apache/aurora/client/commands/test_run.py > 0c395f7a8106acf3d45842a6f536dfb74b71a309 > src/test/python/apache/aurora/client/commands/test_ssh.py > cf9f425b3dd64afe9d8fcfd70495a3c58108824f > src/test/python/apache/aurora/client/commands/test_status.py > 9eb8def26692cf5fbd0c20bc96975125e411f0ba > src/test/python/apache/aurora/client/commands/test_update.py > 555ea0d2727fca61256faf7815945320fcbde55d > src/test/python/apache/aurora/executor/common/__init__.py PRE-CREATION > src/test/python/apache/aurora/executor/common/test_health_checker.py > 2be5b6c7e0e25480a4a48c326bcf22ee248739c1 > src/test/python/apache/aurora/executor/common/test_task_info.py > c4fe9054f7449c056539b755c5cba52f9edad25f > src/test/python/apache/aurora/executor/test_executor_builds.py > 88368f8956a4db8db74ed9d896390db1d5e97fb3 > > Diff: https://reviews.apache.org/r/27364/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > ./build-support/python/make-pycharm-virtualenv > source build-support/python/pycharm.venv/bin/activate > PYTHONPATH=src/main/python py.test src/test/python > > Tested PyCharm Community Edition 3.4. Basic navigation (Ctrl-click) works. > Find usages works. Py.Test works if configured manually. Not a great > experience, but better than no IDE whatsoever for some things. > > > Thanks, > > Kevin Sweeney > >
