-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59591
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java
<https://reviews.apache.org/r/27467/#comment100883>

    Does not read right, s/of/if/?



src/main/java/org/apache/aurora/scheduler/async/KillRetry.java
<https://reviews.apache.org/r/27467/#comment100888>

    How about a stat counter here as well?


- Maxim Khutornenko


On Nov. 1, 2014, 5:48 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 5:48 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
>     https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to