> On Nov. 3, 2014, 6:03 p.m., Joshua Cohen wrote: > > 3rdparty/python/requirements.txt, line 1 > > <https://reviews.apache.org/r/27492/diff/2/?file=747354#file747354line1> > > > > We should be able to skip argparse now that we're pinned to python2.7 > > (it was added to the stdlib).
Didn't even think about that when I was converting the file. Removed. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59600 ----------------------------------------------------------- On Nov. 4, 2014, 12:42 a.m., Dan Norris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27492/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 12:42 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-617 > https://issues.apache.org/jira/browse/AURORA-617 > > > Repository: aurora > > > Description > ------- > > Convert python_requirements links in 3rdparty/python/BUILD to be in > requirements.txt > > > Diffs > ----- > > 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 > 3rdparty/python/requirements.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/27492/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > ...which failed on one test in test_gc_executor.py, but the same test is > failing for me in master. > > > Thanks, > > Dan Norris > >
