I have no idea how this did not fail locally. I have traced the problem
down to improper mocking and I will wait until
https://reviews.apache.org/r/27628 lands before I address it.

On Wed, Nov 5, 2014 at 5:48 PM, Aurora ReviewBot <wfar...@apache.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27657/
>
> Master (0ad2fca) is red with this patch.
>   ./build-support/jenkins/build.sh
>
> src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_cron_status
>  PASSED
> src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_cron_status_multiple_jobs
>  PASSED
> src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_deschedule_cron_deep_api
>  PASSED
> src/test/python/apache/aurora/client/cli/test_cron.py::TestCronNoun::test_schedule_cron_deep_api
>  Fatal error running command; traceback can be found in 
> /home/jenkins/.aurora/errors/aurora-1415238529.error-log
> FAILED
>
> =================================== FAILURES 
> ===================================
> ___________________ TestCronNoun.test_schedule_cron_deep_api 
> ___________________
>
> self = <client.cli.test_cron.TestCronNoun 
> testMethod=test_schedule_cron_deep_api>
>
>     def test_schedule_cron_deep_api(self):
>       (mock_api, mock_scheduler_proxy) = self.create_mock_api()
>       with contextlib.nested(
>           patch('time.sleep'),
>           patch('apache.aurora.client.api.SchedulerProxy', 
> return_value=mock_scheduler_proxy),
>           patch('apache.aurora.client.factory.CLUSTERS', 
> new=self.TEST_CLUSTERS)):
>         mock_scheduler_proxy.scheduleCronJob.return_value = 
> self.create_simple_success_response()
>         with temporary_file() as fp:
>           fp.write(self.get_valid_config())
>           fp.flush()
>           cmd = AuroraCommandLine()
>           result = cmd.execute(['cron', 'schedule', 'west/bozo/test/hello', 
> fp.name])
> >         assert result == EXIT_OK
> E         AssertionError: assert 20 == 0
>
> src/test/python/apache/aurora/client/cli/test_cron.py:100: AssertionError
>  generated xml file: 
> /jenkins/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.cli.cron.xml
> !!!!!!!!!!!!!!!!!!!! Interrupted: stopping after 1 failures 
> !!!!!!!!!!!!!!!!!!!!
> ====================== 1 failed, 3 passed in 1.55 seconds 
> ======================
> Build operating on top level addresses: 
> set([BuildFileAddress(/jenkins/workspace/AuroraBot/src/test/python/BUILD, 
> all)])
> src.test.python.apache.aurora.admin.admin_util                                
>   .....   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance                          
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.api                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator                        
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher                     
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor                          
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.mux                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check                          
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.restarter                            
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client                     
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.sla                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.updater                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.updater_util                         
>   .....   SUCCESS
> src.test.python.apache.aurora.client.binding_helper                           
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.api                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.bridge                               
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks                        
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.cron                                 
>   .....   FAILURE
> src.test.python.apache.aurora.client.config                                   
>   .....   SUCCESS
>
>
> - Aurora ReviewBot
>
> On November 6th, 2014, 1:33 a.m. UTC, Zameer Manji wrote:
>   Review request for Aurora and Bill Farner.
> By Zameer Manji.
>
> *Updated Nov. 6, 2014, 1:33 a.m.*
>  *Bugs: * AURORA-857 <https://issues.apache.org/jira/browse/AURORA-857>
>  *Repository: * aurora
> Description
>
> Print out the job url after scheduling a cron job.
>
>   Testing
>
> ./pants build --timeout=60 src/test/python:all -vxs
>
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 cron schedule 
> devcluster/www-data/test/cron_hello_world 
> /vagrant/examples/jobs/cron_hello_world.aurora
> log(info): Registering job cron_hello_world with cron
> cron schedule created at 
> http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/test/cron_hello_world
>
>   Diffs
>
>    - src/main/python/apache/aurora/client/cli/cron.py
>    (3416c8e1932056725880f2007b60d77112759428)
>    - src/test/python/apache/aurora/client/cli/test_cron.py
>    (f488432cd68cc68fab8fce968e8605625ea3f56a)
>
> View Diff <https://reviews.apache.org/r/27657/diff/>
>



-- 
Zameer Manji

Reply via email to