> On Nov. 6, 2014, 6:06 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/SchedulerActive.java, line 23 > > <https://reviews.apache.org/r/27716/diff/1/?file=754187#file754187line23> > > > > Replace with a meaningful doc, fix formatting.
Done. > On Nov. 6, 2014, 6:06 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 117 > > <https://reviews.apache.org/r/27716/diff/1/?file=754189#file754189line117> > > > > fill in doc Done. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27716/#review60287 ----------------------------------------------------------- On Nov. 6, 2014, 6:41 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27716/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 6:41 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-920 > https://issues.apache.org/jira/browse/AURORA-920 > > > Repository: aurora > > > Description > ------- > > Remove SchedulerActive, replace with explicit services. > > This is the first part of a larger change that will allow us to make pubsub > events async as it makes the dependency on subscribers processing a > SchedulerActive event explicit. > > > Diffs > ----- > > src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > 823ff75559e5155d851d599fd0cd311a03f39daa > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 09c8bc93d95c7a82265730480747554512a0ffd4 > src/main/java/org/apache/aurora/scheduler/TaskVars.java > 3ebb8d0c96a13391438eab9e4b77bf152e9773fd > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java > 1d3978386299d823d9ce6e258760b2f21e48de83 > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > 10465ce54ec2446ce0dd85ec28ad433ebb7f7660 > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > e7fafec45e74008a4eac0787ed9c12b3ce81d4c0 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > b5c8533bafbd13c73371ca1124036a11010e7c20 > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java > 463a3aaffa18240c7d1cb83dfc67903baf2dd707 > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224 > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java > e091ca39f4de43a285575e32ceaa7f1521cf67af > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java > f3c7c5bd53df759432beda4fa46db49fd0514b42 > src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java > 850c9a97df6e3c71bbdeef03fed30153a04b45d8 > > src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java > c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 8baec047a2e0436847ff4558c56428d9d4c2da5a > > Diff: https://reviews.apache.org/r/27716/diff/ > > > Testing > ------- > > ./gradlew -Pq build > test_end_to_end.sh > > > Thanks, > > Kevin Sweeney > >
