> On Nov. 7, 2014, 6:05 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1582 > > <https://reviews.apache.org/r/27712/diff/1/?file=754027#file754027line1582> > > > > Please remove. The API really should not be sending back messages of > > the form "i did what you asked me to do." Sticking strictly to only > > including a response message when it is necessary allows us to have a > > client that is not overly-chatty.
That was simplifying client handling a bit but I see your point. Changed. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27712/#review60352 ----------------------------------------------------------- On Nov. 7, 2014, 12:30 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27712/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 12:30 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-784 > https://issues.apache.org/jira/browse/AURORA-784 > > > Repository: aurora > > > Description > ------- > > Fixing beta-update OK status messaging: > > vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello > aurora/examples/jobs/hello_world.aurora > Job update has started. > vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello > aurora/examples/jobs/hello_world.aurora > Job is unchanged by proposed update. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 175bba24a11587a4c0c595588a01f9e6503442fc > src/main/python/apache/aurora/client/cli/context.py > 0a3c2236916f52919b48e9254929c2fbe9eb5252 > src/main/python/apache/aurora/client/cli/jobs.py > b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0 > src/main/python/apache/aurora/client/cli/quota.py > 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2 > src/main/python/apache/aurora/client/cli/update.py > 0797e30bb40eb983a5ba2f47d1e1955049fb345a > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > b42f6e2d23eb44605cc84ce01a80f10344a7e43f > src/test/python/apache/aurora/client/cli/test_supdate.py > 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359 > > Diff: https://reviews.apache.org/r/27712/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./pants src/tests/python:all > > > Thanks, > > Maxim Khutornenko > >
