-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27698/
-----------------------------------------------------------

(Updated Nov. 7, 2014, 9:17 p.m.)


Review request for Aurora, Kevin Sweeney, Brian Wickman, and Zameer Manji.


Changes
-------

Finished the comment for the deadline. 


Repository: aurora


Description
-------

The underlying Kazoo code here has an uninterruptable wait on the main thread, 
which means if there are any problems establishing a connection then you need 
to hard kill the client process. Moving the code to a separate thread.  


Diffs (updated)
-----

  src/main/python/apache/aurora/client/api/scheduler_client.py 
3a851cc9f53380b4bf2e9df47080e7c476c3e38e 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1f1c6e0ab686cc63bf0a6b7a36e7eef688644e74 

Diff: https://reviews.apache.org/r/27698/diff/


Testing
-------

./pants src/test/python/apache/aurora/client:all
src.test.python.apache.aurora.client.api.api                                    
.....   SUCCESS
src.test.python.apache.aurora.client.api.disambiguator                          
.....   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher                       
.....   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor                            
.....   SUCCESS
src.test.python.apache.aurora.client.api.mux                                    
.....   SUCCESS
src.test.python.apache.aurora.client.api.quota_check                            
.....   SUCCESS
src.test.python.apache.aurora.client.api.restarter                              
.....   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client                       
.....   SUCCESS
src.test.python.apache.aurora.client.api.sla                                    
.....   SUCCESS
src.test.python.apache.aurora.client.api.updater                                
.....   SUCCESS
src.test.python.apache.aurora.client.api.updater_util                           
.....   SUCCESS
src.test.python.apache.aurora.client.binding_helper                             
.....   SUCCESS
src.test.python.apache.aurora.client.cli.api                                    
.....   SUCCESS
src.test.python.apache.aurora.client.cli.bridge                                 
.....   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks                          
.....   SUCCESS
src.test.python.apache.aurora.client.cli.config                                 
.....   SUCCESS
src.test.python.apache.aurora.client.cli.cron                                   
.....   SUCCESS
src.test.python.apache.aurora.client.cli.help                                   
.....   SUCCESS
src.test.python.apache.aurora.client.cli.inspect                                
.....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    
.....   SUCCESS
src.test.python.apache.aurora.client.cli.logging                                
.....   SUCCESS
src.test.python.apache.aurora.client.cli.plugins                                
.....   SUCCESS
src.test.python.apache.aurora.client.cli.quota                                  
.....   SUCCESS
src.test.python.apache.aurora.client.cli.sla                                    
.....   SUCCESS
src.test.python.apache.aurora.client.cli.supdate                                
.....   SUCCESS
src.test.python.apache.aurora.client.cli.task                                   
.....   SUCCESS
src.test.python.apache.aurora.client.cli.update                                 
.....   SUCCESS
src.test.python.apache.aurora.client.commands.admin                             
.....   SUCCESS
src.test.python.apache.aurora.client.commands.core                              
.....   SUCCESS
src.test.python.apache.aurora.client.commands.hooks                             
.....   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance                       
.....   SUCCESS
src.test.python.apache.aurora.client.commands.run                               
.....   SUCCESS
src.test.python.apache.aurora.client.commands.ssh                               
.....   SUCCESS
src.test.python.apache.aurora.client.config                                     
.....   SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api                           
.....   SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api                       
.....   SUCCESS


Thanks,

David McLaughlin

Reply via email to