-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27747/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-917
    https://issues.apache.org/jira/browse/AURORA-917


Repository: aurora


Description
-------

These fail-fast checks finalize the cron/non-cron split in v2 job creation:


Diffs
-----

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
175bba24a11587a4c0c595588a01f9e6503442fc 
  src/main/python/apache/aurora/client/cli/cron.py 
e0510df2f0e076c96d08e7b8562573e4b487479c 
  src/main/python/apache/aurora/client/cli/jobs.py 
b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 b42f6e2d23eb44605cc84ce01a80f10344a7e43f 
  src/test/python/apache/aurora/client/cli/test_create.py 
1dec54c0da234cccc6d4091bb3fda4508836aac0 
  src/test/python/apache/aurora/client/cli/test_cron.py 
029a0c57c32ad799165099de165328ad7e81369a 
  src/test/python/apache/aurora/client/cli/util.py 
154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d 

Diff: https://reviews.apache.org/r/27747/diff/


Testing
-------

./gradlew -Pq build
./pants src/tests/python:all

vagrant@192:~$ aurora2 job create devcluster/vagrant/test/cron_hello_world4 
aurora/examples/jobs/cron_hello_world.aurora
Error executing command: Cron jobs may only be scheduled with "aurora cron 
schedule" command

vagrant@192:~$ aurora2 cron schedule devcluster/www-data/prod/hello 
aurora/examples/jobs/hello_world.aurora
Error executing command: Non-cron jobs may only be created with "aurora job 
create" command


Thanks,

Maxim Khutornenko

Reply via email to