-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27762/#review60447
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java
<https://reviews.apache.org/r/27762/#comment101849>

    This will introduce the unhandled error hiding fixed earlier for most 
executor cases via AsyncUtil helpers. Mind using an AsyncUtil created executor 
instead? 
    
    There is a TODO somewhere to add a non-scheduled executor but it does not 
have to be addressed now.


- Maxim Khutornenko


On Nov. 8, 2014, 12:39 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27762/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2014, 12:39 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-920
>     https://issues.apache.org/jira/browse/AURORA-920
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change uses AsyncEventBus in production code. Some test code still 
> expects eventSink.post() to block. I plan to address in a follow-up review.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> cd5aa17b24209b186314f431c65062d6ed9972cb 
> 
> Diff: https://reviews.apache.org/r/27762/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to