----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27828/#review60677 -----------------------------------------------------------
Ship it! Ship It! - Kevin Sweeney On Nov. 10, 2014, 12:50 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27828/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 12:50 p.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-913 > https://issues.apache.org/jira/browse/AURORA-913 > > > Repository: aurora > > > Description > ------- > > Simplify `AttributeStore.Mutable` by removing `setMaintenanceMode`, and > remove the silent merging behavior performed internally. > > This change sets the stage for fixing AURORA-913, where i will introduce a > thin layer over `HostAttributeStore.Mutable` for the purposes of advertising > when attributes change. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/Maintenance.java > a7a807dd87bf695cb744891256950c4d4840969a > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > 2d382f752fb8d5997ad1f72100a8e032b7625656 > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > 21cfebdf11e0652e192cf08e35c8581b1246f7b5 > src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java > 8ca0dfdf07852c41dfcf43fad298780d0a45153b > src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java > c8b3095ef44b3221e8c58f2b2ecd58e3175f13b4 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 094d1c66e1f464687e0416bc652dba4b1bda0f7e > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java > af15c9543a9be4ad9916423ae650114d2b33aec2 > > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java > 4d96761e04a342ad3564bdba4afdc889f27ac123 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java > c0a1aa5096b507b440d4fe55d68292331c3cd903 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 55a47844aea4c7ced5d7053a62bef29dc97698da > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > ab0d501aac0c187d8fb9791ad43ef586b3aed5e7 > > Diff: https://reviews.apache.org/r/27828/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
