> On Nov. 11, 2014, 12:43 a.m., Aurora ReviewBot wrote: > > Master (01958b1) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py > > (namespace package) > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py > > (namespace package) > > > > Installing > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.string-0.3.0-py2.7-nspkg.pth > > Running setup.py install for twitter.common.options > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py > > (namespace package) > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py > > (namespace package) > > > > Installing > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.options-0.3.0-py2.7-nspkg.pth > > Running setup.py install for twitter.common.dirutil > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py > > (namespace package) > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py > > (namespace package) > > > > Installing > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.dirutil-0.3.0-py2.7-nspkg.pth > > Running setup.py install for twitter.common.contextutil > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py > > (namespace package) > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py > > (namespace package) > > > > Installing > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.contextutil-0.3.0-py2.7-nspkg.pth > > Running setup.py install for twitter.common.lang > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py > > (namespace package) > > Skipping installation of > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py > > (namespace package) > > > > Installing > > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.lang-0.3.0-py2.7-nspkg.pth > > Successfully installed twitter.checkstyle pyflakes pep8 GitPython > > twitter.common.app gitdb twitter.common.process twitter.common.log > > twitter.common.util twitter.common.collections async smmap > > twitter.common.string twitter.common.options twitter.common.dirutil > > twitter.common.contextutil twitter.common.lang > > Cleaning up... > > E303:ERROR src/test/python/apache/aurora/client/cli/test_restart.py:058 > > too many blank lines (3) > > |class TestRestartCommand(AuroraClientCommandTest): > > > > T302:ERROR src/test/python/apache/aurora/client/cli/test_restart.py:058 > > Expected 2 blank lines, found 3 > > |class TestRestartCommand(AuroraClientCommandTest): > > > > E303:ERROR src/test/python/apache/aurora/client/cli/test_supdate.py:076 > > too many blank lines (3) > > |class TestUpdateCommand(AuroraClientCommandTest): > > > > T302:ERROR src/test/python/apache/aurora/client/cli/test_supdate.py:076 > > Expected 2 blank lines, found 3 > > |class TestUpdateCommand(AuroraClientCommandTest): > > > > E303:ERROR src/test/python/apache/aurora/client/cli/test_kill.py:108 too > > many blank lines (3) > > |class TestClientKillCommand(AuroraClientCommandTest): > > > > T302:ERROR src/test/python/apache/aurora/client/cli/test_kill.py:108 > > Expected 2 blank lines, found 3 > > |class TestClientKillCommand(AuroraClientCommandTest): > > > > E303:ERROR src/test/python/apache/aurora/client/cli/test_update.py:080 > > too many blank lines (3) > > |class TestUpdateCommand(AuroraClientCommandTest): > > > > T302:ERROR src/test/python/apache/aurora/client/cli/test_update.py:080 > > Expected 2 blank lines, found 3 > > |class TestUpdateCommand(AuroraClientCommandTest):
Strange: $ ./build-support/python/checkstyle-check tw-172-25-139-176:incubator-aurora dmclaughlin$ - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review60723 ----------------------------------------------------------- On Nov. 11, 2014, 12:29 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27848/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 12:29 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-885 > https://issues.apache.org/jira/browse/AURORA-885 > > > Repository: aurora > > > Description > ------- > > Add friendly error message to the client when lock is held. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > 67cf40365b38b6bf395c697faf0cdb334322bdc3 > src/main/python/apache/aurora/client/cli/context.py > a5ebbdc2ca37c5fd1813854d0a34f15511e6ca06 > src/main/python/apache/aurora/client/cli/jobs.py > 28f9475c5accb8c73cbc5f7a1010920479a0388e > src/main/python/apache/aurora/client/cli/options.py > 1f5cbb616828932742e6482867e2eca9401aad61 > src/test/python/apache/aurora/client/cli/test_create.py > 1dec54c0da234cccc6d4091bb3fda4508836aac0 > src/test/python/apache/aurora/client/cli/test_kill.py > 78f5f04507d7fe080a1ed5ddda692e52f66cc18d > src/test/python/apache/aurora/client/cli/test_restart.py > a8180a3264ac1aa2ade654985755a4dbe262dc47 > src/test/python/apache/aurora/client/cli/test_supdate.py > 09f6a85aebdbf0ad9c9816684f4574132205ee65 > src/test/python/apache/aurora/client/cli/test_update.py > a5e59e4924618ab97f18ea056ef8225e864a317d > src/test/python/apache/aurora/client/cli/util.py > 154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d > > Diff: https://reviews.apache.org/r/27848/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client/cli/:all > ./build-support/python/isort-check > ./build-support/python/checkstyle-check > > > Thanks, > > David McLaughlin > >
