> On Nov. 10, 2014, 6:47 p.m., Joshua Cohen wrote: > > build-support/jenkins/review_feedback.py, lines 75-76 > > <https://reviews.apache.org/r/27770/diff/1/?file=755277#file755277line75> > > > > diffs and latest_diff_time both seem unused here?
Thanks, fixed. > On Nov. 10, 2014, 6:47 p.m., Joshua Cohen wrote: > > build-support/jenkins/review_feedback.py, line 109 > > <https://reviews.apache.org/r/27770/diff/1/?file=755277#file755277line109> > > > > Is it worth excluding src/main/resources? (I suspect the chances of a > > resource-only change are pretty slim, so might not be worth the effort for > > the rare false positive). Yeah, i'm going to punt for now. Will revisit if it becomes a pain. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27770/#review60631 ----------------------------------------------------------- On Nov. 8, 2014, 4:24 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27770/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2014, 4:24 a.m.) > > > Review request for Aurora, David McLaughlin and Joshua Cohen. > > > Repository: aurora > > > Description > ------- > > Make it easier to request another ReviewBot run, and flag diffs that seem to > lack test coverage. > > > Diffs > ----- > > build-support/jenkins/review_feedback.py > 718c538631a7977589e13ddae8db9301f3887c7e > > Diff: https://reviews.apache.org/r/27770/diff/ > > > Testing > ------- > > Ran locally to trigger a build here: https://reviews.apache.org/r/27710/ > > > Thanks, > > Bill Farner > >
