----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/#review61087 -----------------------------------------------------------
Ship it! Ship It! - Zameer Manji On Nov. 12, 2014, 10:58 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27902/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 10:58 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-913 > https://issues.apache.org/jira/browse/AURORA-913 > > > Repository: aurora > > > Description > ------- > > The big change here is to store `IHostAttributes` in `HostOffer` rather than > `MaintenanceMode`, and consume that in the scheduling pipeline. Most of the > source code changes are trivial, but there was significant fallout in tests. > > Apologies again for the large diff. I could further break this up at API > boundaries, but the review burden would be identical without reduced risk. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/HostOffer.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/TaskLauncher.java > c13520a0a7c82ba9ed9cb6f8e49b471e7081b91a > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java > 250c2df8113adfd62b3a7e124f7994156c82b5f7 > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java > 79d8d8d2e28665a6f2439d6242e58b9ce297875a > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java > dd8a9005f1cdade662b418b197d5dfe480c65fa6 > src/main/java/org/apache/aurora/scheduler/async/Preemptor.java > a17738e9b7f718184d8b46ff90a5c6d50d26aad6 > > src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java > d15d9e6b626b4cffd905b53deb1f3007bb7880bb > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java > b23457e0e64b490297166131a1b1b51b6d330415 > > src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java > fc17cac1088f9f9744126923c26862f6e4d7b4e0 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java > c37272c9f46c086cb57b79a5202b3bd80e156f07 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > 0533baa5e90ca62b8d35ba05474eaa8e27741a5a > src/main/java/org/apache/aurora/scheduler/http/Offers.java > 446dc74e1f7f053299747d149ed181a93634eae8 > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > ffcbc975dbc2377b3a1d7ec5606fbec35ee696cf > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > 077699ff400ebe36eae5e608220ab83e0171c4db > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > 9c9b659f9d4be0768489c4e4e124050ccb665d05 > src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java > 844a38a285f7abf917a844a7f6a4a14749aa9b57 > src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java > 083a63543e5f9041f13fc6be66877f7173a5bf32 > src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java > 758a8d419b45d9d890e714fd24020d2bbfa98c3f > src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java > e2a198add4da03ea0d8daf4f9614193f5fb04d6e > src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java > c0fa462c0ebe0b06fa354f5f63d5965827c669a1 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java > 0e699c99314782dcb511bd33dfb5ca50fb3dac75 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java > 7cf5d3ed5e180b1fa1408ce77f8ffa28f2b3bf6e > > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java > 0318179cd70661890f5a53908d1985d54474d476 > > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java > bffbf83653535ecd9bf7b149e1e564c5fba56d17 > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java > 052562fdb63e62b0cfbd6709ba67331f2592250c > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java > 563c1be4a89c2d057d1841690f6351322833c690 > > Diff: https://reviews.apache.org/r/27902/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
