----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61201 -----------------------------------------------------------
Ship it! lgtm once bot agrees, please follow-up with a ticket for fixing the import sorter if the current patch passed it src/test/python/apache/aurora/client/cli/test_kill.py <https://reviews.apache.org/r/27848/#comment102722> this seems like a strange place to place this import (but lgtm if the tool says it's fine) src/test/python/apache/aurora/client/cli/test_restart.py <https://reviews.apache.org/r/27848/#comment102723> strange place for an import - should be in the 3rdparty section. did you run isort-run? - Kevin Sweeney On Nov. 12, 2014, 5:48 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27848/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 5:48 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-885 > https://issues.apache.org/jira/browse/AURORA-885 > > > Repository: aurora > > > Description > ------- > > Add friendly error message to the client when lock is held. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/updater_util.py > 2dd44e3a30202c6359d52a3499aa09f507cc26ca > src/main/python/apache/aurora/client/cli/__init__.py > 67cf40365b38b6bf395c697faf0cdb334322bdc3 > src/main/python/apache/aurora/client/cli/context.py > a5ebbdc2ca37c5fd1813854d0a34f15511e6ca06 > src/main/python/apache/aurora/client/cli/jobs.py > 28f9475c5accb8c73cbc5f7a1010920479a0388e > src/main/python/apache/aurora/client/cli/options.py > 1f5cbb616828932742e6482867e2eca9401aad61 > src/test/python/apache/aurora/client/cli/test_create.py > 1dec54c0da234cccc6d4091bb3fda4508836aac0 > src/test/python/apache/aurora/client/cli/test_kill.py > 78f5f04507d7fe080a1ed5ddda692e52f66cc18d > src/test/python/apache/aurora/client/cli/test_restart.py > a8180a3264ac1aa2ade654985755a4dbe262dc47 > src/test/python/apache/aurora/client/cli/test_supdate.py > 09f6a85aebdbf0ad9c9816684f4574132205ee65 > src/test/python/apache/aurora/client/cli/test_update.py > a5e59e4924618ab97f18ea056ef8225e864a317d > src/test/python/apache/aurora/client/cli/util.py > 154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d > > Diff: https://reviews.apache.org/r/27848/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client/cli/:all > ./build-support/python/isort-check > ./build-support/python/checkstyle-check > > > Thanks, > > David McLaughlin > >
