----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28066/#review61835 -----------------------------------------------------------
Ship it! Ship It! - Kevin Sweeney On Nov. 14, 2014, 5:53 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28066/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 5:53 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-798 > https://issues.apache.org/jira/browse/AURORA-798 > > > Repository: aurora > > > Description > ------- > > Looking at the EeasyMock.Results it does not appear to be thread safe wrt > call count recording. That resulted in about 20% flakiness that I could repro > locally. Replacing the exact count expectations by .atLeastOnce() as the test > conditions are still asserted by the CountdownLatch. > > > Diffs > ----- > > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java > 6e499d1d82d5748ffc0d578283139f39e93316a7 > > Diff: https://reviews.apache.org/r/28066/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
