> On Nov. 19, 2014, 12:50 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/client/commands/core.py, line 180 > > <https://reviews.apache.org/r/28250/diff/1/?file=770246#file770246line180> > > > > Why was the logic moved out of here?
@app.command does arg introspection that causes execution to fail with a pretty horrible stack trace when extra kwargs are added to a top-level command. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28250/#review62222 ----------------------------------------------------------- On Nov. 19, 2014, 12:44 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28250/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:44 p.m.) > > > Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Zameer > Manji. > > > Bugs: AURORA-938 > https://issues.apache.org/jira/browse/AURORA-938 > > > Repository: aurora > > > Description > ------- > > Fix test_version to use explicit injection points. > > > Diffs > ----- > > src/main/python/apache/aurora/client/commands/core.py > 852b6b1ba479a8781133f2331fb75f8122a36855 > src/test/python/apache/aurora/client/commands/test_version.py > 5c3c45a769aeec2ffb2c2bd3d8d937476c9abd12 > > Diff: https://reviews.apache.org/r/28250/diff/ > > > Testing > ------- > > ./pants src/test/python:all > ./pants src/main/python/apache/aurora/client/bin:aurora_client > dist/aurora_client.pex version > > > Thanks, > > Kevin Sweeney > >
