-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27705/#review62256
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/TaskVars.java
<https://reviews.apache.org/r/27705/#comment104269>

    This should be the only dynamic one, right?  Rack/host limit?  Value 
constraints can be considered static.



src/main/java/org/apache/aurora/scheduler/TaskVars.java
<https://reviews.apache.org/r/27705/#comment104270>

    I don't have strong data to back this up, but i'm concerned about the 
performance impact here.  In a large/busy cluster, this could be invoked 
O(100k) times per second.  Can you avoid the Set creation?  Maybe instead just 
loop and use two flags?
    
    To combat this, we really need to move the nearest fit/miss calculation to 
the publisher end (which would, unfortunately, break these stats).  For now, i 
think it makes sense to merely be cognizant of the call frequency.


- Bill Farner


On Nov. 15, 2014, 12:15 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27705/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2014, 12:15 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-914
>     https://issues.apache.org/jira/browse/AURORA-914
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding @Timed to trace scheduling latencies and Veto counters per type.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 6bfa3ac425ed3045fa60d1b0ca547e9bf3cde37a 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 4821a7890b77ccb04c10bee6d8b4b9e7216940cc 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> 3839083f27ca5d4b93406152559b58b04e912a10 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> c1c5f26723f1eac3000e09e061b4582f922fded6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> cc6b53b3265253f76c1e954c0108aa5936f5cc36 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 87203690f09456ac1ca5e9da2b82826d60cbd723 
>   src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java 
> aaedb3b5ec2cb27550449435efa8f335c6a9baad 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> 12ea4c67350c2992f59bacd21a99d1413b60b757 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  94f0a179b786649775899f855f7c1a0caab7290f 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  e113eba1f304279b5ee3d70db1d1ea558efd63ac 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  608903268a0a0d67711bfdc81d2e5b29c335ead2 
> 
> Diff: https://reviews.apache.org/r/27705/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> Verified new stats in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to