-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28272/#review62317
-----------------------------------------------------------


In addition to having a comment in code, can you add some info to this review 
or the JIRA ticket about how you came to the conclusion that this will benefit? 
I'm assuming this is just designed to reduce object allocations and GC churn? 
What sort of improvement in terms of % of objects created during a snapshot 
should we expect?


src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java
<https://reviews.apache.org/r/28272/#comment104342>

    Can you add a comment explaining why we're doing this?


- David McLaughlin


On Nov. 20, 2014, 1:08 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28272/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 1:08 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-930
>     https://issues.apache.org/jira/browse/AURORA-930
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java
>  7b46740a5beb4b5bde4b5d41bea9573195e047b9 
> 
> Diff: https://reviews.apache.org/r/28272/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> Suggestions on how to better test this are welcome.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to