----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62477 -----------------------------------------------------------
Master (ada97bd) is red with this patch. ./build-support/jenkins/build.sh + date Fri Nov 21 01:01:15 UTC 2014 + ./gradlew -Pq clean build :buildSrc:clean UP-TO-DATE :buildSrc:compileJava UP-TO-DATE :buildSrc:compileGroovy :buildSrc:processResources UP-TO-DATE :buildSrc:classes :buildSrc:jar :buildSrc:assemble :buildSrc:compileTestJava UP-TO-DATE :buildSrc:compileTestGroovy UP-TO-DATE :buildSrc:processTestResources UP-TO-DATE :buildSrc:testClasses UP-TO-DATE :buildSrc:test UP-TO-DATE :buildSrc:check UP-TO-DATE :buildSrc:build :clean :bootstrapThrift :checkPython :generateSources :compileGeneratedJavaNote: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :processGeneratedResources UP-TO-DATE :generatedClasses :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :assemble :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java:93:13: Variable 'i' must be private and have accessor methods. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. > Checkstyle rule violations were found. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 29.996 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 21, 2014, 12:54 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28306/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 12:54 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-930 > https://issues.apache.org/jira/browse/AURORA-930 > > > Repository: aurora > > > Description > ------- > > Stream frame chunks instead of preallocating them. > > This avoids allocating an entire additional snapshot worth of heap during > entry serialization, reducing overall heap impact of the serializer from > 2*sizeof(serialized-entry) to sizeof(serialized-entry)+chunkSize. > > Further optimizations out-of-scope for this change: > > * Make the returned iterator mutate a fixed-size buffer (for GC pressure > avoidance). > * Change the log format so that FrameHeader doesn't need to know the size and > checksum of the serialized data ahead-of-time (maybe write it as a trailer). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java > f4fa1cb740633ced529c1b5fd9f18abba8944571 > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java > cb95d8996a934751745f423b79279266d73b7722 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > c90389433d81dd72756c659736e38fd9f66fcb35 > > Diff: https://reviews.apache.org/r/28306/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > >
