> On Nov. 21, 2014, 10:10 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, 
> > lines 170-171
> > <https://reviews.apache.org/r/28193/diff/2/?file=772029#file772029line170>
> >
> >     It doesn't look like there's a test case for this scenario, can you add 
> > one?

"testExecutorInfoNoOverhead" does this with the ram property.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62574
-----------------------------------------------------------


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
>     https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to