-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 10:10 p.m.)
Review request for Aurora, Bhuvan Arumugam, Joshua Cohen, and Maxim Khutornenko.
Changes
-------
Add thermos_runner to the list of apache.thermos binary entry points so that
it's picked up when depending on the apache.thermos distribution.
Bugs: AURORA-823
https://issues.apache.org/jira/browse/AURORA-823
Repository: aurora
Description
-------
Move thermos_runner out of the apache.aurora.executor package.
The drawback of having it in the apache.aurora.executor package is that if we
want to build a thermos_runner binary from the apache.aurora.executor
distribution, it transitively pulls in mesos.native, making the thermos_runner
pex like 70MB. thermos_runner.pex really only has dependencies within
apache.thermos and the thermos_runner exit-code contract is a bit more clear
now, so putting it into apache.thermos makes a bit more sense now. it also
makes thermos_runner.pex 566k instead of 70MB. it also fixes AURORA-823.
Diffs (updated)
-----
examples/vagrant/aurorabuild.sh 4d51cee1c19ed677e08000f03de1c9050e85832b
src/main/python/apache/aurora/executor/BUILD
ca4193d31e3e3a71fa45f918058fba40fc911487
src/main/python/apache/aurora/executor/bin/BUILD
a41cf950b707ac47486b7eeeef869edba1fc9e42
src/main/python/apache/aurora/executor/bin/thermos_runner_main.py
f61caf038db0be4decc4acfe4a2a378de28be50b
src/main/python/apache/aurora/executor/thermos_runner.py
e10f43896bda4c3ed3c879168e42e104aff89483
src/main/python/apache/aurora/executor/thermos_statuses.py
src/main/python/apache/aurora/executor/thermos_task_runner.py
9a2faa06325c23c41b64f3d0a1422d849c03f278
src/main/python/apache/thermos/BUILD 04574647f787387846b71e71a397577bda54616b
src/main/python/apache/thermos/bin/BUILD
34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
src/main/python/apache/thermos/common/BUILD
918800b4ccb7bef61249d488ca8a4255168311bb
src/test/python/apache/aurora/executor/test_thermos_executor.py
16a40111da055268f7ab396a3a4ea38176c526a3
src/test/python/apache/aurora/executor/test_thermos_task_runner.py
4fc9d4b7eced0a5d65d09be6c66e30f555d8734b
Diff: https://reviews.apache.org/r/28345/diff/
Testing
-------
build-support/jenkins/build.sh
firing off an integration test run right now.
Thanks,
Brian Wickman
