> On Nov. 21, 2014, 11:32 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/cli/test_cron.py, lines 218-227 > > <https://reviews.apache.org/r/28350/diff/1/?file=772866#file772866line218> > > > > This block is repeated ~verbatim 4x in this file. Cleaning up the > > underlying code to improve testing is probably too high of a bar, but you > > could at least extract a helper function to minimize the spread.
Obviated by refactoring. > On Nov. 21, 2014, 11:32 p.m., Bill Farner wrote: > > docs/cron-jobs.md, line 90 > > <https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line90> > > > > This makes it seem like only the _execution schedule_ is changed by > > this command, not the template. Suggest rewording to mkae it more obvious > > that this will update subsequent cron executions. Good point. Reworded. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28350/#review62675 ----------------------------------------------------------- On Nov. 21, 2014, 11:14 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28350/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 11:14 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-921 > https://issues.apache.org/jira/browse/AURORA-921 > > > Repository: aurora > > > Description > ------- > > Implementing "aurora cron replace" command to close the functionality gap > that will be created with client updater removal. > > > Diffs > ----- > > docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7 > docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72 > src/main/python/apache/aurora/client/api/__init__.py > d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 > src/main/python/apache/aurora/client/cli/cron.py > cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2 > src/main/python/apache/aurora/client/cli/update.py > 12774af8bcd1c953fdbc799b0a142c27407d69f5 > src/test/python/apache/aurora/client/api/test_api.py > 1f4e9fe9111ac88726d7c45b699b3b91438448b6 > src/test/python/apache/aurora/client/cli/test_cron.py > c748212febf5867f5f7cc54e34bf91a8890d9999 > src/test/python/apache/aurora/client/cli/test_supdate.py > 7637352feea6b07408256158814c05bc17ec14f3 > > Diff: https://reviews.apache.org/r/28350/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > tested in vagrant as well > > > Thanks, > > Maxim Khutornenko > >
