> On Dec. 3, 2014, 2:06 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java,
> >  line 56
> > <https://reviews.apache.org/r/28607/diff/2/?file=780608#file780608line56>
> >
> >     This can be further simplified (unless you are concerned about the heap 
> > churn):
> >     ```java
> >     victims.remove(slaveId, 
> > PreemptionVictim.fromTask(stateChange.getTask().getAssignedTask());
> >     ```

Good suggestion, this also removed some surrounding code.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28607/#review63637
-----------------------------------------------------------


On Dec. 3, 2014, 1:39 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28607/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 1:39 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-121
>     https://issues.apache.org/jira/browse/AURORA-121
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a caching ClusterState implementation.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java 
> 3524dc595e7b61a531912843f90b01a87bc57cc4 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
>  489c0bfa22aae14fbd3fd2ee9e5bd32b7c3aafa5 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterStateTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to