----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ -----------------------------------------------------------
(Updated Dec. 8, 2014, 3:18 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes ------- Add unit test for logging plugin. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description ------- This patch makes multiple changes to simplify the logging done in the Aurora client: 1. Remove the TRANSCRIPT log level and replaced all instances with the standard Python DEBUG level. 2. Remove the custom "aurora_client" logger. This logger was designed to give each invocation of the client a unique id and record the username of the user with the intention that a hook could take this information and ship it to the cluster administer. However a hook could capture logs by adding a handler to the root log handler and generate a unique id itself. 3. Remove the 'print_log' method of the context and replaced all callers with the standard python logging facilities. 4. Removed duplicate printing/logging messages by just printing the information to the user. 5. Removed the custom PlainFormatter implementation and replaced it with Python's default formatter. 6. Replaced the "--verbose-logging" and "--logging-level" flags with a single "--verbose/-v" flag which enables DEBUG logging. Without this flag the user sees INFO and up. Diffs (updated) ----- src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/task.py 91175facdc8ccccc9fd59ab66781f86ee8b5940a src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/cli/test_client.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_task.py c69a624ec7063973d365846f7df3516047ceeb68 Diff: https://reviews.apache.org/r/28742/diff/ Testing ------- ./pants ./src/test/python/apache/aurora:: ```` vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 config list ./aurora/examples/jobs/hello_world.aurora jobs=[devcluster/www-data/prod/hello] vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job create devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Creating job hello INFO] Checking status of devcluster/www-data/prod/hello job create succeeded: job url=http://vagrant-ubuntu-trusty-64:8081/scheduler/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job list devcluster/* INFO] Retrieving jobs for role None devcluster/www-data/prod/hello vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0, 1] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Examining instance: 1 INFO] Adding instance: 1 INFO] Added: 1 INFO] Watching instances: [1] INFO] Instance 1 was not reported healthy within 60 seconds INFO] Failed instances: set([1]) WARN] Not restarting failed instances [1], which exceeded maximum allowed instance failure limit of 0 ERROR] 1 failed instances observed, maximum allowed is 0 ERROR] 1 instance failures for instance 1, maximum allowed is 0 INFO] Reverting update for: [1, 0] INFO] Processing in parallel with 1 worker thread(s) INFO] Reverting instance: 1 INFO] Examining instance: 1 INFO] Killing instance: 1 INFO] Killed: 1 INFO] Reverting instance: 0 INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 WARN] Update failures threshold reached Update failed due to error: Update reverted Error executing command: Update failed due to error: vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job update devcluster/www-data/prod/hello ./aurora/examples/jobs/hello_world.aurora INFO] Updating job: hello INFO] Instances to update: [0] INFO] Processing in parallel with 1 worker thread(s) INFO] Examining instance: 0 INFO] Skipping unchanged instance: 0 INFO] Update successful Update completed successfully vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/prod/hello INFO] Checking status of devcluster/www-data/prod/hello INFO] Killing tasks for job: devcluster/www-data/prod/hello INFO] Instances to be killed: [0] Successfully killed shards [0] job killall succeeded ```` Thanks, Zameer Manji