----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64333 -----------------------------------------------------------
thanks for the drive-by cleanups! src/test/python/apache/aurora/client/cli/test_kill.py <https://reviews.apache.org/r/28831/#comment106977> I believe this should be of the form `assert foo.mock_calls == [x]` Ditto elsewhere. - Bill Farner On Dec. 9, 2014, 1:25 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28831/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 1:25 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-961 > https://issues.apache.org/jira/browse/AURORA-961 > > > Repository: aurora > > > Description > ------- > > Also, cleaned up kill command tests a bit. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/options.py > e844cf340583b631ce194352f403bbaec71655b7 > src/test/python/apache/aurora/client/cli/test_kill.py > 1eda72af4c19831ae27733f506858e67772b2075 > src/test/python/apache/aurora/client/cli/util.py > 67d7eaa6eff4e1dbaaa485166e084812a4f04074 > > Diff: https://reviews.apache.org/r/28831/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client/cli:all > > > Thanks, > > Maxim Khutornenko > >
