----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28872/#review64441 -----------------------------------------------------------
Ship it! Master (9926af3) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 9, 2014, 9:30 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28872/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 9:30 p.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-469 > https://issues.apache.org/jira/browse/AURORA-469 > > > Repository: aurora > > > Description > ------- > > A minor fix improving the quota check message on the client. Minor enough to > consider for a dying client updater. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/quota_check.py > c994050d76a9b617f70dfcbf60cf10e02d4a4bb9 > src/test/python/apache/aurora/client/api/test_quota_check.py > 2fc76d21ca63ae7f33b1e03ccb88f52fe82dc76c > > Diff: https://reviews.apache.org/r/28872/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client/api:quota_check > > Vagrant: > ``` > $ aurora2 job update devcluster/www-data/prod/hello > aurora/examples/jobs/hello_world.aurora > INFO] > INFO] > INFO] Updating job: hello > INFO] Not enough quota to create/update job. > INFO] Total allocated quota for www-data: > CPU 2.0 > RAM 2.000000 GB > Disk 2.000000 GB > INFO] Consumed quota for www-data: > CPU 1.9 > RAM 1.125977 GB > Disk 1.125000 GB > INFO] Requested for hello: > CPU 9.1 > RAM 0.000000 GB > Disk 0.000000 GB > INFO] Additional quota required for www-data: > CPU 9.0 > RAM 0.000000 GB > Disk 0.000000 GB > Update failed due to error: > Unable to start job update: Response from scheduler: INVALID_REQUEST > (message: Failed quota check.) > Error executing command: Update failed due to error: > ``` > > > Thanks, > > Maxim Khutornenko > >
