> On Dec. 17, 2014, 6:57 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 174
> > <https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174>
> >
> >     Why do we need a deep copy here?

The "[task] * config.instances()" creates a shallow array. Without a deep copy, 
any subsequent elements will attempt to modify an already modified element 
failing the json.loads() call.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65341
-----------------------------------------------------------


On Dec. 17, 2014, 6:24 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29137/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 6:24 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-691
>     https://issues.apache.org/jira/browse/AURORA-691
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Dual reading populated configs to make sure we are backwards compatible by 
> 0.8.0.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/updater.py 
> 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
>   src/main/python/apache/aurora/client/base.py 
> a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
>   src/main/python/apache/aurora/client/commands/core.py 
> 7b970e8872c73a30947ce8f407c37da3d06f20df 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> dad69e20598c1daf62706989dafcb4be50fed82b 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 95c7c92942c7cbde344a093789b3e04b63200cc5 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> c19b21dd99dded0fdc631cef90997e2f2bd1156e 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
>   src/test/python/apache/aurora/client/commands/test_diff.py 
> b48b53d3282d25c74a8424efe15ad19493acb3a5 
>   src/test/python/apache/aurora/client/commands/test_restart.py 
> 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
>   src/test/python/apache/aurora/client/test_base.py 
> fba08aeb8103aaa62fb86c389a1976f89289a086 
> 
> Diff: https://reviews.apache.org/r/29137/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client:all
> Verified in vagrant. 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to