> On Dec. 29, 2014, 8:36 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java, > > line 39 > > <https://reviews.apache.org/r/29464/diff/1/?file=802787#file802787line39> > > > > have you run checkstyle? method names are lowerCamelCase
Yeah, good catch, I'm still not out of C# world yet. checkstyleMain didn't pick this up though oddly enough. There are a couple other things it did though, new patch set coming up with those fixes. > On Dec. 29, 2014, 8:36 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java, > > line 51 > > <https://reviews.apache.org/r/29464/diff/1/?file=802787#file802787line51> > > > > Why not ask for the IP address to advertise on the command-line? It > > looks like by the time this is called it's too late for us to do anything > > with a DNS resolution error. I'd rather publish the actual DNS name rather than the IP in this case (since the underlying IP could change over time). I agree though this should fail-fast at app start rather than the first time the service registry is used (which is also at startup, but it'll be more explicit the other way). > On Dec. 29, 2014, 8:36 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java, > > line 21 > > <https://reviews.apache.org/r/29464/diff/1/?file=802787#file802787line21> > > > > Convention is to place CmdLine Args in Guice Modules (to separate > > wiring from implementation). Also, this value will need to be plumbed into > > the mesos Log somehow. Ok cool, I can make that change. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/#review66297 ----------------------------------------------------------- On Dec. 29, 2014, 8:23 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29464/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 8:23 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > I've added a new flag for the aurora scheduler, -dns_name_override which can > override the scheduler server address published into ZK. > > This is useful for cases such as running the scheduler in EC2, where the > autodetected local address is actual an interal IP and not the public address > of the machine. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 > > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > cf173850635572c0df38bdd5cb14de8ce2016bf7 > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java > c3bf5ea4cbeaad03e187f84215b86531d55c25b3 > > Diff: https://reviews.apache.org/r/29464/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
