----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29491/#review66680 -----------------------------------------------------------
Ship it! LGTM with a few nits. src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java <https://reviews.apache.org/r/29491/#comment110262> move declaration to the line before the value is used src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java <https://reviews.apache.org/r/29491/#comment110263> ditto - Bill Farner On Jan. 5, 2015, 6:36 p.m., Issam EL ATIF wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29491/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 6:36 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > [AURORA-986] RequestLoggerTest failed for Locale.FRANCE > > > Diffs > ----- > > src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java > 298a34e1a23716cf63ccc02c0ebc9945490fd7bb > > Diff: https://reviews.apache.org/r/29491/diff/ > > > Testing > ------- > > All tests in RequestLoggerTest pass now. > > > Thanks, > > Issam EL ATIF > >
