> On Jan. 5, 2015, 6:55 p.m., Bill Farner wrote:
> > Can you add details about why this is being done?  At a quick glance, it 
> > appears as though we're relying on transitive dependencies of pex, but i 
> > suspect there's more to it.

We were depending on all of twitter.common.python for only pex. Depending on 
pex directly lets us more easily consume upstream pex changes without going 
through the dance of getting a new version of t.c.p published.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29586/#review66687
-----------------------------------------------------------


On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29586/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 7:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Replace twitter.common.python dependency with a direct pex dependency (at the 
> latest version).
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 05bbf338196cced9f01bf1fadf65682e14dbdf99 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/commands/BUILD 
> 78a2f57b4b42edf363f40e2988cf9a69c36ad003 
>   src/main/python/apache/aurora/common/BUILD 
> 1c6464d8a91a84ca74191814edacaac5e83b78e8 
>   src/main/python/apache/aurora/common/pex_version.py 
> 6aecd8a14eff7cd58becbecc8b05ea193a6c9cec 
>   src/main/python/apache/aurora/executor/BUILD 
> 72d1ec5e891a4b7b5101ae913f7520609ccd98a8 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7c018271724ffab2ff6930e5802a48b50a39dded 
>   src/test/python/apache/aurora/common/test_pex_version.py 
> 7280f703463c6205493a718310f20a7fd21a0c6b 
> 
> Diff: https://reviews.apache.org/r/29586/diff/
> 
> 
> Testing
> -------
> 
> ./pants build src/test/python/apache/aurora:all
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to