> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 192
> > <https://reviews.apache.org/r/28971/diff/1/?file=789836#file789836line192>
> >
> >     while at it, how about s/shard/instance/g/

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 256
> > <https://reviews.apache.org/r/28971/diff/1/?file=789836#file789836line256>
> >
> >     missing trailing '>'

Fixed.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 320
> > <https://reviews.apache.org/r/28971/diff/1/?file=789836#file789836line320>
> >
> >     drop '-shards' option here

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 370
> > <https://reviews.apache.org/r/28971/diff/1/?file=789836#file789836line370>
> >
> >     s/config/<job_configuration>

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 392
> > <https://reviews.apache.org/r/28971/diff/1/?file=789836#file789836line392>
> >
> >     s/pathname/<job_configuration>

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 406
> > <https://reviews.apache.org/r/28971/diff/1/?file=789836#file789836line406>
> >
> >     same here

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/BUILD, line 102
> > <https://reviews.apache.org/r/28971/diff/1/?file=789841#file789841line102>
> >
> >     +1 to renaming the artifact

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/BUILD, line 105
> > <https://reviews.apache.org/r/28971/diff/1/?file=789841#file789841line105>
> >
> >     s/aurora2/aurora

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 38
> > <https://reviews.apache.org/r/28971/diff/1/?file=789848#file789848line38>
> >
> >     drop?

Thanks, restored in a way that works.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review65152
-----------------------------------------------------------


On Dec. 11, 2014, 10:53 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
>     https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -----
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 2a66825426923fd7e5b7c70101747bc292208e19 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c2eb89cae536838ac4dd46b0125a248d84f6e54c 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> -------
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to