> On Jan. 7, 2015, 9:48 p.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/client/commands/test_diff.py, line 82 > > <https://reviews.apache.org/r/29672/diff/1/?file=809105#file809105line82> > > > > While you're here mind changing these to kwargs form? That will make > > this test actually fail if the thrift API renames or removes these fields.
This is a very short lived fix as https://reviews.apache.org/r/29216/ will drop this file completely along with other v1 code. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29672/#review67099 ----------------------------------------------------------- On Jan. 7, 2015, 9:30 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29672/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 9:30 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Deepcopy chokes on a mock object. No idea how it could ever pass before. > > > Diffs > ----- > > src/test/python/apache/aurora/client/commands/test_diff.py > 81cdd116b324cb985f6fe05f0e0e50984bd5095c > > Diff: https://reviews.apache.org/r/29672/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client/commands:core > > > Thanks, > > Maxim Khutornenko > >
