-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29734/#review67347
-----------------------------------------------------------


Ugh, I just messed that diff up.

- Joshua Cohen


On Jan. 9, 2015, 12:38 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29734/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 12:38 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix reviewbot to skip reviews that have no diffs.
> 
> We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) 
> of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that 
> has no diffs. This should fix those cases.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/review_feedback.py 
> bd2c9941960645f662ec835c2baa4d1f3dae7d79 
>   docs/client-commands.md 75e69541fd95dfd9a7aa1e04de1a590b8fcbeacf 
>   docs/client.md 3ec39b4f3bd6b45692aa1291e66a0a171d7dbb68 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 395819fdf24b7919b32be51060fb5b581c8e1514 
>   src/main/python/apache/aurora/client/cli/client.py 
> 939e32b0287a4a6e9cd66c4d6ffe05b32ed26d78 
>   src/main/python/apache/aurora/client/cli/options.py 
> b7f5a031d135a33ec2d79aa521ce9c1438eb58c1 
>   src/main/python/apache/aurora/client/cli/task.py 
> e084c5bef54d8a726276764ed7e5ce44cdc99ec5 
>   src/test/python/apache/aurora/client/cli/BUILD 
> bbac5c8efc9892fd2a966a6ac25fe05ffd740733 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 9fa05e683f01a0e51253e08aa7fba69fd49d3756 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> cf742a3feb12c6bb8fc6e80f15daaac7c2b2bf55 
>   src/test/python/apache/aurora/client/cli/util.py 
> 1fa1207d9380e57ac77d2aa24725b9ac39c83d4c 
> 
> Diff: https://reviews.apache.org/r/29734/diff/
> 
> 
> Testing
> -------
> 
> Ran locally, it didn't crash on r28943
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to